lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254250115
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -311,11 +310,11 @@ private static RuntimeException
convertDdlException(Throwable e) {
}
if (e instanceof IgniteInternalCheckedException) {
- return new IgniteInternalException(DDL_EXEC_ERR, "Failed to
execute DDL statement [stmt=" /*+ qry.sql()*/
+ return new IgniteInternalException(RUNTIME_EXECUTION_ERR, "Failed
to execute DDL statement [stmt=" /*+ qry.sql()*/
+ ", err=" + e.getMessage() + ']', e);
}
- return (e instanceof RuntimeException) ? (RuntimeException) e : new
SqlException(DDL_EXEC_ERR, e);
+ return (e instanceof RuntimeException) ? (RuntimeException) e : new
SqlException(RUNTIME_EXECUTION_ERR, e);
Review Comment:
`CompletableFuture` wraps all exceptions in `CompletionException`, so we
should not get `ExecutionException ` here, unless of course we have a custom
`CompletableFuture/CompletionStage` that does not bother itself with such
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
