lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1262341880


##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########


Review Comment:
   @korlov42 What should be done with these:
   
   >if (!busyLock.enterBusy()) {
   >  return CompletableFuture.failedFuture(new 
SqlException(SESSION_NOT_FOUND_ERR, "Session is closed."));
   >}
   



##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########


Review Comment:
   @korlov42 What should be done with these blocks:
   
   >if (!busyLock.enterBusy()) {
   >  return CompletableFuture.failedFuture(new 
SqlException(SESSION_NOT_FOUND_ERR, "Session is closed."));
   >}
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to