aiai-bot commented on issue #3961: URL: https://github.com/apache/hertzbeat/issues/3961#issuecomment-3744189781
<!-- code-pr-reviewer --> Thank you for reporting this issue. The bug appears valid based on the error logs showing TDengine SQL syntax errors with unescaped special characters (`.`, `:`) in TAGS values like `10.1.1.1:53` for DNS monitoring. Evidence suggests the issue was introduced in PR #3863 when `instance` became the sub-table name/TAGS value without proper escaping for TDengine's character restrictions. Key files: - `hertzbeat-warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/history/tsdb/tdengine/TdEngineDataStorage.java` (INSERT SQL construction) - `hertzbeat-warehouse/src/test/java/org/apache/hertzbeat/warehouse/store/TdEngineDataStorageTest.java` (test coverage) Before proceeding: 1. Should the fix adopt the "dynamic table name strategy" (e.g., `_v2` suffix) mentioned in the discussion, or implement character escaping per TDengine specs? 2. Is backward compatibility with existing TDengine tables required, or can users drop/recreate them? 3. Should we also audit InfluxDB/IoTDB/QuestDB for similar special character handling issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
