Saramanda9988 commented on issue #3961: URL: https://github.com/apache/hertzbeat/issues/3961#issuecomment-3739624767
Hi @Duansg , Thanks for your trust. I’ve reviewed the code and current situation again, and here are my perspectives on the points you raised: For this bug, your guidance is correct. In my opinion, since the insertion has been consistently failing, the database is effectively in a "vacuum" state for affected users. Therefore, I believe there is no actual data loss for these users, and we also need to fix the query-related issue. For historical metrics migration, I’m not entirely sure how much users value historical data (e.g., last 7 days, 1 month, or longer). Actually, in my previous PR, I tried to implement a "compatible query" approach —— querying twice, once by instance and once by monitorId, and merging the results. However, I felt the performance overhead was high for very low returns, so I removed it. Since I didn't receive specific guidance on this during that PR's review, I kept the current instance-only query logic. Referring to Issue #3765, it was mentioned by Tom that: "QuestDB, TDengine, and IoTDB are not in the plan for the future, I think we do not need to be compatible with these." Based on this, I believe guiding users to delete old/incompatible data is the better choice: 1. Most TSDBs lack migration mechanisms like Flyway. Manual migration by users is prone to unnecessary data loss. 2. This approach clearly communicates our future development roadmap to the community. Regarding other databases, I will coordinate with you to perform regression tests as needed to ensure system-wide stability. I'd love to hear your thoughts on this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
