Duansg commented on issue #3961: URL: https://github.com/apache/hertzbeat/issues/3961#issuecomment-3739384438
> Hi, This appears to be due to the lack of necessary escaping for special characters (such as dots, colons) in the instance during insertion in the [#3863](https://github.com/apache/hertzbeat/pull/3863) refactoring > > I'd be happy to take care of the fix to save you some time. Would you like me to submit a PR [@Duansg](https://github.com/Duansg) Ok, thanks, it is indeed due to the refactoring, but there are several issues that need attention. 1. Failure due to incorrect insertion type ``` CREATE STABLE IF NOT EXISTS `%s` `%s` TAGS (monitor BIGINT) ``` 2. Even if the insertion is normal, the historical metrics will become invalid. The Prometheus application is accessed via ``` if (CommonConstants.PROMETHEUS.equals(monitor.getApp())) { appDefine.setApp(CommonConstants.PROMETHEUS_APP_PREFIX + monitor.getName()); } ``` 3. The type of the TAG column is fixed. The official TDEngine documentation states: `You cannot modify tag columns of other types.` Should we consider a fallback approach of rebuilding or guiding deletion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
