On Thu, 30 Apr 2026 14:39:28 GMT, Daniel Fuchs <[email protected]> wrote:
>> src/java.base/share/classes/java/net/Socket.java line 1756:
>>
>>> 1754: * independent of each other. Irrespective of whether or not the
>>> socket
>>> 1755: * is {@linkplain #close() closed}, this method will return
>>> {@code true} only
>>> 1756: * if a prior call to {@linkplain #shutdownInput()
>>> shutdownInput()}
>>
>> Since the link text is the method name (even including the `()`), would
>> `@link` instead of `@linkplain` be more appropriate, to have it formatted as
>> code?
>> Suggestion:
>>
>> * if a prior call to {@link #shutdownInput()}
>>
>>
>> Same applies to `isOutputShutdown`.
>>
>> (This is just a suggestion; feel free to ignore.)
>
> Yes - it should be `{@link ... }` sorry I missed that! Same for other method
> references in the new text.
Fixed. The shutdownInput() and shutdownOutput() were the only two places in the
new text, where using `{@link ...}` seemed appropriate. I've left the other
linkplain in the new text as-is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31000#discussion_r3168765876
