On Thu, 30 Apr 2026 13:29:20 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve the text
>
> src/java.base/share/classes/java/net/Socket.java line 1757:
>
>> 1755: * for a closed socket if {@linkplain #shutdownInput()
>> shutdownInput()}
>> 1756: * completed successfully prior to the socket being closed.
>> 1757: *
>
> For me it would be more surprising if this method returned `false` after
> `close()` if `shutdownInput()` hadn't be called before `close()`. Is that
> what is implied here?
> I would naively expect `isInputShutdown()` to return `true` after `close()`
> always, regardless of whether `shutdownInput()` had been called before
> `close()`, or not.
>
> So I find this new text confusing.
>
> Same for `isOutputShutdown()` below.
Thanks! The new text looks good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31000#discussion_r3168516387
