On Mon, 27 Apr 2026 15:42:39 GMT, Jaikiran Pai <[email protected]> wrote:

>> Can I please get a review of this test-only change which addresses the issue 
>> noted in https://bugs.openjdk.org/browse/JDK-8308878?
>> 
>> The commit in this PR updates the test to not hardcode a IPv4 address and 
>> instead use the server's bound address when looking for the server's IP 
>> address in the output.
>> 
>> With this change the test now passes in IPv4 as well as IPv6 environments.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jaikiran Pai has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - address review comment for Pattern.quote()
>  - merge latest from master branch
>  - 8308878: com/sun/net/httpserver/simpleserver/OutputFilterTest.java fails 
> with assertion errors in IPv6 only environment

Thank you Daniel and @Marcono1234 for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30934#issuecomment-4340356668

Reply via email to