On Mon, 27 Apr 2026 15:22:32 GMT, Marcono1234 <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - address review comment for Pattern.quote()
>> - merge latest from master branch
>> - 8308878: com/sun/net/httpserver/simpleserver/OutputFilterTest.java fails
>> with assertion errors in IPv6 only environment
>
> test/jdk/com/sun/net/httpserver/simpleserver/OutputFilterTest.java line 134:
>
>> 132: var filterOutput = baos.toString(UTF_8);
>> 133: System.err.println("server output:\n" + filterOutput);
>> 134: var pattern = Pattern.compile(serverIP + " " + """
>
> For correctness, should this use `Pattern#quote`? Otherwise the `.` in IPv4
> addresses would match any character?
>
>
> (also applies to the other changes below)
> Suggestion:
>
> var pattern = Pattern.compile(Pattern.quote(serverIP) + " " + """
Thank you for catching that. I've updated the PR to address it. I'll run the
change in our CI.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30934#discussion_r3148478737
