On Mon, 27 Apr 2026 15:38:21 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/com/sun/net/httpserver/simpleserver/OutputFilterTest.java line 134:
>>
>>> 132: var filterOutput = baos.toString(UTF_8);
>>> 133: System.err.println("server output:\n" + filterOutput);
>>> 134: var pattern = Pattern.compile(serverIP + " " + """
>>
>> For correctness, should this use `Pattern#quote`? Otherwise the `.` in IPv4
>> addresses would match any character?
>>
>>
>> (also applies to the other changes below)
>> Suggestion:
>>
>> var pattern = Pattern.compile(Pattern.quote(serverIP) + " " + """
>
> Thank you for catching that. I've updated the PR to address it. I'll run the
> change in our CI.
The test continues to pass with this change in our CI.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30934#discussion_r3154237284
