> Hi all, > > I have migrated these classes to JUnit: > - `jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramSocketNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketNAPITest.java` > > The former `@BeforeTest` has been converted to a static `@BeforeAll`, as this > better reflects the intended scope. > > Additionally, I noticed an issue in the `testSocket` method where > `initialRun` remained `true` for all tests (and conversely remained `false` > in `SocketNAPITest`). > I have corrected this so that the intended consistency check is properly > exercised. > Please let me know if this change introduces any unintended side effects. > > Thanks. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Daisuke Yamazaki has updated the pull request incrementally with one additional commit since the last revision: Refactor NAPI tests to improve variable naming and assertion order ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30964/files - new: https://git.openjdk.org/jdk/pull/30964/files/8977a841..ff17be37 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30964&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30964&range=00-01 Stats: 20 lines in 5 files changed: 5 ins; 5 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/30964.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30964/head:pull/30964 PR: https://git.openjdk.org/jdk/pull/30964
