On Tue, 28 Apr 2026 07:29:38 GMT, Daisuke Yamazaki <[email protected]> wrote:
> Hi all, > > I have migrated these classes to JUnit: > - `jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramSocketNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketNAPITest.java` > > The former `@BeforeTest` has been converted to a static `@BeforeAll`, as this > better reflects the intended scope. > > Additionally, I noticed an issue in the `testSocket` method where > `initialRun` remained `true` for all tests (and conversely remained `false` > in `SocketNAPITest`). > I have corrected this so that the intended consistency check is properly > exercised. > Please let me know if this change introduces any unintended side effects. > > Thanks. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: 91933ed0 Author: Daisuke Yamazaki <[email protected]> Committer: Daniel Fuchs <[email protected]> URL: https://git.openjdk.org/jdk/commit/91933ed01be614f59114e784988eebd86c4d4310 Stats: 167 lines in 6 files changed: 35 ins; 58 del; 74 mod 8381862: Refactor remaining TestNG tests under jdk/net/ExtendedSocketOption to use JUnit Reviewed-by: dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/30964
