On Tue, 28 Apr 2026 07:40:43 GMT, Alan Bateman <[email protected]> wrote:
>> Daisuke Yamazaki has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor NAPI tests to improve variable naming and assertion order
>
> test/jdk/jdk/net/ExtendedSocketOption/DatagramChannelNAPITest.java line 104:
>
>> 102: initialRun = false;
>> 103: } else {
>> 104: assertEquals(receiverID, tempID);
>
> I see you've transposed the parameters for assertEquals in many cases (good),
> there may be a few more that were missed.
Thanks for pointing that out.
After taking another look, I noticed that `tempID` should indeed be treated as
the expected value in `assertEquals`.
That said, the name `tempID` isn't very descriptive, and the fact that it gets
updated event when it's not the initial run feels a bit off relative to the
intent of the test.
So I renamed it to `originalID` and adjusted the update timing accordingly (I
referenced the `AsynchronousSocketChannelNAPITest`).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30964#discussion_r3152448824
