On Mon, 13 Apr 2026 13:48:06 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hi, may I get a review for this change that converts the remaining TestNG >> tests under test/jdk/java/net to JUnit. >> >> An exception is `java/net/NetworkInterface/NetworkInterfaceStreamTest.java` >> which depends on library classes depending on TestNG. Converting that test >> is not done here but is tracked by >> [JDK-8381848](https://bugs.openjdk.org/browse/JDK-8381848) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Review feedback test/jdk/java/net/SocketOption/ImmutableOptions.java line 76: > 74: CustomSocketImpl impl = new CustomSocketImpl(); > 75: assertThrows(UnsupportedOperationException.class, > 76: () -> impl.supportedOptions().clear()); Suggestion: var options = impl.supportedOptions(); assertThrows(UnsupportedOperationException.class, options::clear); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30681#discussion_r3077639076
