On Fri, 10 Apr 2026 20:33:25 GMT, Marcono1234 <[email protected]> wrote:
>> Hi, may I get a review for this change that converts the remaining TestNG >> tests under test/jdk/java/net to JUnit. >> >> An exception is `java/net/NetworkInterface/NetworkInterfaceStreamTest.java` >> which depends on library classes depending on TestNG. Converting that test >> is not done here but is tracked by >> [JDK-8381848](https://bugs.openjdk.org/browse/JDK-8381848) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/java/net/InetAddress/HostsFileOrderingTest.java line 95: > >> 93: String [] expectedAddresses = getExpectedAddressesArray(); >> 94: >> 95: if (Arrays.deepEquals(resolvedAddresses, expectedAddresses)) { > > Could use `assertArrayEquals`? (unless you want to keep the custom error > messages) I'd prefer to keep it as it is - for readability in case of failures. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30681#discussion_r3073115267
