On Fri, 10 Apr 2026 20:57:38 GMT, Marcono1234 <[email protected]> wrote:
>> Hi, may I get a review for this change that converts the remaining TestNG >> tests under test/jdk/java/net to JUnit. >> >> An exception is `java/net/NetworkInterface/NetworkInterfaceStreamTest.java` >> which depends on library classes depending on TestNG. Converting that test >> is not done here but is tracked by >> [JDK-8381848](https://bugs.openjdk.org/browse/JDK-8381848) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/java/net/SocketOption/ImmutableOptions.java line 70: > >> 68: assertThrows(UnsupportedOperationException.class, >> 69: () -> socket.supportedOptions().clear()); >> 70: } > > Here and below, what about moving the `supportedOptions()` call outside the > `assertThrows` to ensure that it doesn't unexpectedly throw the > `UnsupportedOperationException`? Agreed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30681#discussion_r3071458646
