On Fri, 10 Apr 2026 17:27:29 GMT, Mahendra Chhipa <[email protected]> wrote:
>> test/jdk/sun/net/www/protocol/file/DirPermissionDenied.java line 80:
>>
>>> 78: } catch (Exception e) {
>>> 79: throw new RuntimeException("Failed " + e);
>>> 80: }
>>
>> Should these use `assertThrows(IOException.class, ...)` (in case they do
>> actually expect an exception)?
>
> This test is verifying multiple methods in one test. I would like to refactor
> this in another PR to break in multiple tests.
OK. Can you log an issue for that and also mention using assertThrows()? I
believe it's the second call (the one that do or forces connect()) which will
throw the exception.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30645#discussion_r3073731065
