On Fri, 10 Apr 2026 12:40:33 GMT, Marcono1234 <[email protected]> wrote:
>> Following tests are refactored to use JUnit Jupiter API :
>> sun/net/ext/ExtendedSocketOptionsTest.java
>> sun/net/www/protocol/file/DirPermissionDenied.java
>> sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java
>> sun/net/www/protocol/jrt/Basic.java
>> sun/net/www/protocol/http/TestTransparentNTLM.java
>> sun/net/www/protocol/http/HttpHeaderParserTest.java
>> sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
>> sun/net/www/http/KeepAliveStreamCleaner/java.base/sun/net/www/http/KeepAliveStreamCleanerTest.java
>> sun/net/www/http/KeepAliveStreamCleaner/KeepAliveStreamCleanerTestDriver.java
>> sun/net/www/MessageHeaderTest.java
>> sun/net/spi/DefaultProxySelectorTest.java
>
> test/jdk/sun/net/www/protocol/file/DirPermissionDenied.java line 80:
>
>> 78: } catch (Exception e) {
>> 79: throw new RuntimeException("Failed " + e);
>> 80: }
>
> Should these use `assertThrows(IOException.class, ...)` (in case they do
> actually expect an exception)?
This test is verifying multiple methods in one test. I would like to refactor
this in another PR to break in multiple tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30645#discussion_r3065790830
