On Fri, 10 Apr 2026 17:19:07 GMT, Mahendra Chhipa <[email protected]> wrote:
>> test/jdk/sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java line >> 115: >> >>> 113: // If both connectTimeout values are equal, it means the >>> test retrieved the same broken >>> 114: // HttpClient from the cache and is trying to re-use it. >>> 115: assertNotEquals(originalConnectTimeout, >>> cachedConnectTimeout, "Both connectTimeout values are equal.\nThis means >>> the test is reusing a broken HttpClient rather than creating a new one."); >> >> arguments should be swapped. Could you make a pass over all the files and >> double check this please? >> The argument order for JUnit is `(expected, actual [, msg])` > > Here second httpclient (cachedClient) should not be retrieved from cache, > arguments order is correct here. Not expected is originalConnectTimeout and > actual is from new httpclient (cachedclient) Gone through all the files to check the arguments otder. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30645#discussion_r3065758400
