On Tue, 21 Jan 2025 11:08:23 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix `HttpResponse` copyright year
>
> test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 78:
>
>> 76: @ParameterizedTest
>> 77: @MethodSource("sufficientCapacities")
>> 78: void testSuccessOnSufficientCapacity(HttpClient.Version version,
>> boolean secure, long sufficientCapacity) throws Exception {
>
> For this test method and the `testFailureOnInsufficientCapacity` method we
> appear to be creating a server for each parameterized test. That can be
> expensive. I think we can create the HTTP/HTTPS servers before hand (and have
> the handlers registered) and use those servers in these test methods. We use
> a similar strategy in several other tests.
Implemented in 29f9052e0afb2dd191f80767d8704a0a2c3144e0.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1924940199
