On Tue, 21 Jan 2025 10:38:43 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix `HttpResponse` copyright year > > test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 8: > >> 6: * under the terms of the GNU General Public License version 2 only, as >> 7: * published by the Free Software Foundation. Oracle designates this >> 8: * particular file as subject to the "Classpath" exception as provided > > Hello Volkan, for the test files, we don't use the "Classpath" exception > copyright header. You can copy over the copyright text from another existing > test file, to get the correct header. Fixed in ad9de094675f869d5df28530cf41f17acdda0bd5. > test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 93: > >> 91: IOException.class, >> 92: () -> requestBytes(version, secure, >> insufficientCapacity), >> 93: "body exceeds capacity: " + RESPONSE_BODY.length); > > The 3rd parameter here is the message representing the failure of the assert. > In its current form if this test fails (i.e. the IOException isn't thrown), > then the failure message will say "body exceeds capacity: X" which I think is > a bit misleading since it gives an impression that the response body has > exceeded capacity. > > I think changing that message to something like `"No IOException thrown for > capacity: " + insufficientCapacity` might be a bit more clear. Fixed in fc4d674496f26501f8203cd2f77c3d42f98bfdf6. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923508863 PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923508327
