On Tue, 21 Jan 2025 15:17:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 70:
>>
>>> 68: import static org.junit.jupiter.api.Assertions.assertThrows;
>>> 69:
>>> 70: class HttpResponseLimitingTest {
>>
>> I think we should also add test methods to verify that the newly added
>> methods throw a `NullPointerException` and `IllegalArgumentException` for
>> incorrect parameters.
>
> Finally, I think we should also add a test method which verifies that a
> limiting BodyHandler with a specific capacity doesn't impact the headers from
> being delivered to the downstream/wrapped BodyHandler even if the size of the
> response headers exceeds the given capacity.
@jaikiran, pushed 8668a034967acd3340a30391cd5897332a068cf5 to verify the header
parsing. Would you mind reviewing it and resolving this conversation if you
agree with the fix, please?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1925008304
