On Fri, 13 Dec 2024 14:57:42 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add `ConnectSocksProxyTest`
>> - Add `NO_PROXY` case to `ConnectFailTest`
>
> test/jdk/java/net/Socket/ConnectFailTest.java line 165:
>
>> 163: @SuppressWarnings("resource")
>> 164: Socket channelSocket = SocketChannel.open().socket();
>> 165: Socket proxiedSocket = new Socket(Proxy.NO_PROXY);
>
> Adding a Socket created with NO_PROXY is a good idea. On naming
> "proxiedSocket" suggests it's proxies, I think you want noProxySocket :-)
Renamed in ac06d4dc9252e9f55b58b8569d8c578292b72b61.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22719#discussion_r1884091659
