On Thu, 12 Dec 2024 18:26:04 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:

> [JDK-8343791](https://bugs.openjdk.org/browse/JDK-8343791) modified 
> `Socket::connect` to throw `UHE` on unresolved addresses – merged in #22160. 
> As reported in [JDK-8346017](https://bugs.openjdk.org/browse/JDK-8346017), 
> this renders `connect()` unusable when there is a (SOCKS) proxy in play, 
> where calling `connect()` using unresolved addresses is a valid operation. 
> This PR
> 
> 1. Reverts the earlier `Socket::connect` change
> 2. Updates tests accordingly
> 3. Enhances tests with proxied socket inputs
> 
> These changes require CSR and RN tickets. I will implement them once we agree 
> on a solution here.

This pull request has now been integrated.

Changeset: 9e8aa855
Author:    Volkan Yazıcı <volkan.yaz...@oracle.com>
Committer: Daniel Fuchs <dfu...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/9e8aa855fe3483b1a59233bcbd693cd0fed7de8e
Stats:     242 lines in 3 files changed: 223 ins; 8 del; 11 mod

8346017: Socket.connect specified to throw UHE for unresolved address is 
problematic for SOCKS V5 proxy

Reviewed-by: dfuchs, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/22719

Reply via email to