On Thu, 12 Dec 2024 19:11:10 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix `Socket::connect` javadoc > > The update to Socket looks okay, thanks. > > ConnectFailTest is a test for connect failing. I'm tempted to suggest that we > create a new test for SOCKS and not modify ConnectFailTest. With SOCKS then > the connect may succeed with an unresolved address so I think different to > the direct case. Daniel, do you agree on this? @AlanBateman, @dfuch, implemented the following two changes: 1. Added `new Socket(Proxy.NO_PROXY)` case to `ConnectFailTest` 2. Added `ConnectSocksProxyTest` cloning `ConnectFailTest` for a SOCKS proxy socket Together with @dfuch, we decided to postpone the HTTP proxy socket case to a separate future PR, since there is more work there needs to be done there. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22719#issuecomment-2541633452
