On Thu, 21 Nov 2024 22:45:12 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 72:
>> 
>>> 70:      * security property to the desired algorithm name.
>>> 71:      *
>>> 72:      * @see java.security.Security security properties
>> 
>> it looks like unnecessary API changes here
>
> Why do you think it is an API change? It produces the exact same javadoc. 
> Technically it's not related, but minor cleanup changes like this are ok in 
> my opinion.

Yes, you are right, javadoc is the same. So, not entirely correct about API.
But the same exact place in the KeyManagerFactory is not modified. I do not 
know the exact policy about references in the javadoc. I prefer to have a full 
class name if not in the same package. But, from my point of view, it is better 
to have consistent changes in similar places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22301#discussion_r1853074640

Reply via email to