On Tue, 19 Nov 2024 14:44:18 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java >> line 56: >> >>> 54: >>> 55: /** >>> 56: * Create a BasicAuthentication >> >> Good cleanup. I see `Serializable` was removed from `AuthCacheValue` when >> fixing JDK-8304818, it was an oversight to not remove `serialVersionUID` >> from subclasses at that time. I see you're removing it from >> `DigestAuthentication`, `NTLMAuthentication` and `NegotiateAuthentication` >> too. This is good. You seem to be missing the window's version of >> `NTLMAuthentication` though. > > Maybe we should consider making this class `final` too. That's a good catch about the Windows variant of `NTLMAuthentication`. I have updated the PR to address it. Additionally, I've also marked these authentication classes as `final`. tier1, tier2 and tier3 testing will these latest changes in this PR continues to pass. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22232#discussion_r1849524980
