On Tue, 19 Nov 2024 09:54:43 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this code which cleans up usages of > SecurityManager and related APIs? This addresses > https://bugs.openjdk.org/browse/JDK-8344190. > > No new tests have been added and testing of tier1, tier2, tier3 is in > progress. Pfew! That's a lot of complex code going away! Good work! A few minor comments. Well, actually, just one. Please make sure to run all tier1,tier2,tier3 tests. src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java line 56: > 54: @java.io.Serial > 55: private static final long serialVersionUID = 100L; > 56: Good cleanup. I see `Serializable` was removed from `AuthCacheValue` when fixing JDK-8304818, it was an oversight to not remove `serialVersionUID` from subclasses at that time. I see you're removing it from `DigestAuthentication`, `NTLMAuthentication` and `NegotiateAuthentication` too. This is good. You seem to be missing the window's version of `NTLMAuthentication` though. src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java line 71: > 69: cacheSPNEGO = Boolean.parseBoolean(spnegoCacheProp); > 70: } > 71: Removing that static initializer was missed when fixing JDK-8318599. src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java line 74: > 72: > 73: public class NTLMAuthentication extends AuthenticationInfo { > 74: private static final long serialVersionUID = 170L; There is also a windows implementation of this class ------------- PR Review: https://git.openjdk.org/jdk/pull/22232#pullrequestreview-2445683773 PR Review Comment: https://git.openjdk.org/jdk/pull/22232#discussion_r1848489990 PR Review Comment: https://git.openjdk.org/jdk/pull/22232#discussion_r1848523670 PR Review Comment: https://git.openjdk.org/jdk/pull/22232#discussion_r1848667999
