On Tue, 19 Nov 2024 14:40:29 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Can I please get a review of this code which cleans up usages of >> SecurityManager and related APIs? This addresses >> https://bugs.openjdk.org/browse/JDK-8344190. >> >> No new tests have been added and testing of tier1, tier2, tier3 is in >> progress. > > src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java > line 56: > >> 54: @java.io.Serial >> 55: private static final long serialVersionUID = 100L; >> 56: > > Good cleanup. I see `Serializable` was removed from `AuthCacheValue` when > fixing JDK-8304818, it was an oversight to not remove `serialVersionUID` from > subclasses at that time. I see you're removing it from > `DigestAuthentication`, `NTLMAuthentication` and `NegotiateAuthentication` > too. This is good. You seem to be missing the window's version of > `NTLMAuthentication` though. Maybe we should consider making this class `final` too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22232#discussion_r1848496804
