On Thu, 20 Oct 2022 10:51:07 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   blank line removed
>
> src/jdk.httpserver/share/classes/module-info.java line 86:
> 
>> 84:  * </li>
>> 85:  * <li><p><b>{@systemProperty sun.net.httpserver.debug}</b> (default: 
>> false)<br>
>> 86:  * Boolean value, which if true, generates debug information on the 
>> console.
> 
> Should we instead say that it generates the debug information on `{@link 
> System#out}`, since that's where we direct those logs and the `System.out` 
> can be anything (if the application changes it to something else).

This looks like debug and it probably shouldn't be documented - or possibly 
replaced by regular logger calls since the httpserver uses java.util.logging. 
What is the reason for using `dprint` instead of regular j.u.l as is done 
elsewhere in the server implementation?

-------------

PR: https://git.openjdk.org/jdk/pull/10766

Reply via email to