On Thu, 20 Oct 2022 14:30:24 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Hi, >> >> This change adds some documentation to the jdk.httpserver module-info >> listing all of the system properties used by the implementation and which >> can be set by users. >> >> CSR at https://bugs.openjdk.org/browse/JDK-8295667 >> >> Thanks, >> Michael. > > Michael McMahon has updated the pull request incrementally with one > additional commit since the last revision: > > after review src/jdk.httpserver/share/classes/module-info.java line 58: > 56: * The maximum number of idle connections at a time. > 57: * </li> > 58: * <li><p><b>{@systemProperty sun.net.httpserver.drainAmount}</b> > (default: 64K)<br> Hello Michael, sorry I missed this in my previous review. The value for `drainAmount` is expected to be a `long` value. So I think the default value here should be `65536`. Readers might take the `64K` value literally and might attempt to pass similar values to this property which will then lead to failures. ------------- PR: https://git.openjdk.org/jdk/pull/10766
