On Thu, 20 Oct 2022 08:05:09 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Hi, >> >> This change adds some documentation to the jdk.httpserver module-info >> listing all of the system properties used by the implementation and which >> can be set by users. >> >> CSR at https://bugs.openjdk.org/browse/JDK-8295667 >> >> Thanks, >> Michael. > > Michael McMahon has updated the pull request incrementally with one > additional commit since the last revision: > > blank line removed src/jdk.httpserver/share/classes/module-info.java line 83: > 81: * exceeded then the connection is terminated and the handler will > receive a > 82: * {@link java.io.IOException}. This timer has an implementation specific > granularity > 83: * that may mean responses are aborted later than the specified interval. I think the `maxReqTime` and the `maxRspTime` will need a bit more clarification on how they differ. Specifically the `maxReqTime` as used by the current server implementation is the duration to read the entire request content. It however, doesn't include the time it takes to generate the response nor process the request through the handler. src/jdk.httpserver/share/classes/module-info.java line 86: > 84: * </li> > 85: * <li><p><b>{@systemProperty sun.net.httpserver.debug}</b> (default: > false)<br> > 86: * Boolean value, which if true, generates debug information on the > console. Should we instead say that it generates the debug information on `{@link System#out}`, since that's where we direct those logs and the `System.out` can be anything (if the application changes it to something else). ------------- PR: https://git.openjdk.org/jdk/pull/10766
