On 17 November 2015 at 15:12, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Nov 17, 2015 at 7:09 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> On Tue, Nov 17, 2015 at 4:04 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> Hi Jason, >>> >>> On 12 November 2015 at 01:26, Jason Ekstrand <ja...@jlekstrand.net> wrote: >>>> --- >>>> src/mesa/drivers/dri/i965/brw_fs.cpp | 11 +++++++++-- >>>> src/mesa/drivers/dri/i965/brw_nir.c | 1 - >>>> src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 ++++- >>>> src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 6 +++++- >>>> 4 files changed, 18 insertions(+), 5 deletions(-) >>>> >>> Can you please add a couple of lines why we want this. This way it >>> will be beneficial to you and/or others while skimming through git log >>> X weeks down the line. >> >> Sure. I can do that. > > I added: > > This allows us to insert NIR passes between initial NIR compilation and > optimization (link time) and actual backend code-gen. In particular, it > will allow us to do shader variants in NIR and share some of that shader > variant code between backends.
As a person not that deep into the i965 code-base to provide meaningful review - thank you. It looks great. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
