On 09/10/2015 12:35 PM, Ilia Mirkin wrote: > On Thu, Sep 10, 2015 at 3:31 PM, Ian Romanick <i...@freedesktop.org> wrote: >> On 09/08/2015 10:20 PM, Ilia Mirkin wrote: >>> On Tue, Sep 8, 2015 at 11:46 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>>> On Tue, Sep 8, 2015 at 11:38 PM, Ian Romanick <i...@freedesktop.org> wrote: >>>>> On 09/08/2015 08:17 PM, Ian Romanick wrote: >>>>>> On 09/08/2015 08:10 PM, Ilia Mirkin wrote: >>>>>>> I'll give it a shot on NVIDIA and see what happens... my tests might >>>>>>> require GL 3.2 because I didn't want to deal with the various >>>>>>> differences that happen otherwise. >>>>>> >>>>>> That should be good enough. Perhaps someone else can try on AMD >>>>>> closed-source drivers. If they both ignore the spec, then I feel pretty >>>>>> comfortable ignoring it too... while I work on getting it changed. >>>>> >>>>> I have attached the spec changes that I am proposing. >>>> >>>> This drops the dependence on images, which means that gallium drivers >>>> can get this straight away. From a "allow the extension to run on as >>>> many devices as possible" standpoint, this makes sense. There's an >>>> alternate viewpoint which is that this should perhaps require *both* >>>> images and ARB_texture_multisample (without requiring any specific >>>> GLSL version). >>>> >>>> I've only looked at things from the driver writer's standpoint, i.e. >>>> "make as many exts available as possible", so I'm definitely in favor >>>> :) But I could also easily live with leaving the images requirement in >>>> there. >>> >>> BTW, I knew something felt off about your change... I just figured out >>> what -- there is no GLSL 3.20 :) There's a GL 3.2 and a GLSL 1.50. >> >> Hot off the presses... with s/3.20/1.50/, my change was accepted. This >> should show up in the Khronos registry "soon." > > Nice! Of course this means that older GPUs that don't support images > at all can now get this extension (like nv50, snb, r600/r700). And > GPUs that do support images but whose driver writers are behind the > times (like all the gallium ones). > > I won't modify this series to also support SNB, but perhaps I'll do that > later. > >> >> Patch 1 is also >> >> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > Thanks! > > Ken gave me a R-b for the whole series, I plan on pushing some time > today unless I hear objections or I happen to discover some sort of > issue.
Cool. I sent comments and R-bs on all the glsl: and mesa: patches. That's all I plan to review. > -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
