On Friday, March 27, 2015 04:57:45 PM Ilia Mirkin wrote: > On Fri, Mar 27, 2015 at 4:54 PM, Eric Anholt <e...@anholt.net> wrote: [snip] > > +#ifndef PIPELINE_H > > +#define PIPELINE_H > > + > > +/** > > + * Bitflags for system values. > > + */ > > +#define SYSTEM_BIT_SAMPLE_ID BITFIELD64_BIT(SYSTEM_VALUE_SAMPLE_ID) > > +#define SYSTEM_BIT_SAMPLE_POS BITFIELD64_BIT(SYSTEM_VALUE_SAMPLE_POS) > > +#define SYSTEM_BIT_SAMPLE_MASK_IN BITFIELD64_BIT(SYSTEM_VALUE_SAMPLE_MASK_IN) > > Please include whatever defines BITFIELD64_BIT, otherwise including > just this file will cause compilation errors.
Which raises an interesting point. That header is mtypes.h, so how does splitting this out actually help anything at all? FWIW, I think moving those declarations to src/util/bitset.h might not be a crazy plan. Or, you could always just open code it - it's just ((GLbitfield64)1 << (b)) aka (1ull << b) anyway.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
