On Friday, March 27, 2015 01:54:30 PM Eric Anholt wrote: > NIR uses these enums/#defines in nir_variables and associated intrinsics, > but I want to be able to use them from TGSI->NIR and NIR->TGSI. > Otherwise, we had to pull in all of mtypes.h. > > This doesn't cover all of the enums we might want from a shared compiler > core (like varying slots or vert attribs), but it at least covers what I > need at the moment (system values and interp qualifiers). > --- > src/mesa/main/mtypes.h | 135 +-------------------------------------- > src/util/pipeline.h | 170 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 171 insertions(+), 134 deletions(-) > create mode 100644 src/util/pipeline.h
Pulling these out of mtypes.h seems like a fine plan. However, I don't think the new header really belongs in src/util. src/util is meant for memory allocation libraries, data structures, atomic code, and other generic sort of helper stuff. This is clearly compiler stuff - maybe put it in src/glsl or src/mesa/program?
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
