Sorry, said that just a little early. Do we really want 4 bits for a floating-point format? How many bits does nvidia report? --Jason
On Wed, Aug 6, 2014 at 9:55 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > This looks fine to me. > Reviewed-by: Jason Ekstrand <jason.ekstr...@intel.com> > > > On Wed, Aug 6, 2014 at 9:27 AM, Neil Roberts <n...@linux.intel.com> wrote: > >> Adds the ‘bptc’ layout to get_channel_bits. The channel bits for BPTC >> depend >> on the mode but as it only has to be an approximation we can set it to 4 >> like >> for S3TC. >> --- >> src/mesa/main/format_info.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/mesa/main/format_info.py b/src/mesa/main/format_info.py >> index a0eecd3..fc40dc4 100644 >> --- a/src/mesa/main/format_info.py >> +++ b/src/mesa/main/format_info.py >> @@ -110,7 +110,7 @@ def get_channel_bits(fmat, chan_name): >> if fmat.is_compressed(): >> # These values are pretty-much bogus, but OpenGL requires that we >> # return an "approximate" number of bits. >> - if fmat.layout == 's3tc': >> + if fmat.layout in ('s3tc', 'bptc'): >> return 4 if fmat.has_channel(chan_name) else 0 >> elif fmat.layout == 'fxt1': >> if chan_name in 'rgb': >> -- >> 1.9.3 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev >> > >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev