Am Sonntag, 4. Juni 2006 13:38 schrieb Abdelrazak Younes: > I've seen your patch and I will work on it afterward. Now, I just want > to fix was is obviously wrong. Up to now, "QClipboard::Selection" is > used everywhere so it's not like I am removing something.
No, you don't remove anything. > "QClipboard::Selection" doesn't make sense under Mac and Windows so I am > fixing that. But in a wrong way. I know that the system clipboard does not work at all on windows, and I understand that you want to fix it. My argument is: If you are going to touch this, please do it the right way. IMO an unimplemented clipboard is better than a clipboard with non-standard behaviour. > > I do care about the correct handling of selection vs. clipboard. I > > explained to Edwin why simply using QClipboard::Clipboard on windows > > instead of QClipboard::Selection on unix is a bad idea, and now I see you > > did exactly that. > > Sorry but QClipboard::Selection is not supported on Windows so my fix is > right. No, it is not. I already wrote to Edwin: With his original patch (and also yours) it will be possible to paste the system clipboard with the middle mouse button. That is wrong! Also a simple mouse selection (without pressing C-C) will put something into the system clipboard. That is also wrong. > As I said, the clipboard is broken also on X11 as it uses only the mouse > selection mode. Depends on the definition of broken. I would say that it is not broken, but partly not implemented. The mouse selection mode works as it should: Selecting something makes it available to X, and middle mouse button pastes the selection. > I can feel you are switching to grumpy mode Georg. That's not my > intention. I am just trying to fix this whole thing. IMHO, clipboard > support has no business in the WorkArea class. My patch is a necessary > cleanup before the further fixes and feature enhancements you are proposing. Here we disagree: IMO it is not necessary (but I don't really care as I wrote already). I am not going grumpy, I only try to convince you that you should fix the clipboard correctly and not with a hack, because a) it is not much more work and b) hacks like that tend to stay forever. > Please find an updated patch with proper Bufferview support. Could you > please test that this patch compile for qt3/gtk/xforms ? I will do that after you addressed Angus' comments. Georg
