Georg Baum wrote:
Am Sonntag, 4. Juni 2006 13:38 schrieb Abdelrazak Younes:
"QClipboard::Selection" doesn't make sense under Mac and Windows so I am
fixing that.
But in a wrong way. I know that the system clipboard does not work at all
on windows, and I understand that you want to fix it. My argument is: If
you are going to touch this, please do it the right way. IMO an
unimplemented clipboard is better than a clipboard with non-standard
behaviour.
Note that I am not touching the X11 clipboard at all. With my patch, it
would have stayed the same.
I do care about the correct handling of selection vs. clipboard. I
explained to Edwin why simply using QClipboard::Clipboard on windows
instead of QClipboard::Selection on unix is a bad idea, and now I see
you
did exactly that.
Sorry but QClipboard::Selection is not supported on Windows so my fix is
right.
No, it is not. I already wrote to Edwin: With his original patch (and also
yours) it will be possible to paste the system clipboard with the middle
mouse button. That is wrong! Also a simple mouse selection (without
pressing C-C) will put something into the system clipboard. That is also
wrong.
OK, I'll remove it.
As I said, the clipboard is broken also on X11 as it uses only the mouse
selection mode.
Depends on the definition of broken. I would say that it is not broken,
but partly not implemented.
That's my point.
The mouse selection mode works as it should:
Selecting something makes it available to X, and middle mouse button
pastes the selection.
I can feel you are switching to grumpy mode Georg. That's not my
intention. I am just trying to fix this whole thing. IMHO, clipboard
support has no business in the WorkArea class. My patch is a necessary
cleanup before the further fixes and feature enhancements you are
proposing.
Here we disagree: IMO it is not necessary (but I don't really care as I
wrote already).
I am not going grumpy, I only try to convince you that you should fix the
clipboard correctly and not with a hack, because a) it is not much more
work and b) hacks like that tend to stay forever.
I said that I was going to fix it the proper way after my
reorganisation. Your patch is touching a lot of things everywhere. I
already plan to have a hard time convincing Lars and JMarc about my
change to BufferView so I don't feel like having to justify your change
at the same time. Besides I don't know much the code your patch is touching.
So for now, I will just put back the broken QClipboard::Selection.
Abdel.
