Am Sonntag, 4. Juni 2006 12:36 schrieb Abdelrazak Younes: > Please find an updated patch. I think it is OK now but I worked on it a > bit more. I had to change a bit the other frontends because I removed > clipboard methods from WorkArea and put them in a new Clipboard class. I > have also transfered the cliboard code to Application.[Ch].
Why? I don't really care whether the clipboard methods are in an own class or not. I do care about the correct handling of selection vs. clipboard. I explained to Edwin why simply using QClipboard::Clipboard on windows instead of QClipboard::Selection on unix is a bad idea, and now I see you did exactly that. The patch I sent yesterday seems basically to work, but it needs some fine tuning and testing. I hoped that Edwin would do that. I don't have the time to polish this further, I only created the patch because Edwin felt a bit lost and I wanted to encourage him to do the proper fix. Please either do nothing about the broken clipboard on windows, or fix it in a way that does not violate the selection/clipboard definition on http://www.freedesktop.org/wiki/Standards_2fclipboards_2dspec. This should not be too difficult to do with the patch I sent yesterday, besides some testing it only needs some code to disable LFUN_PRIMARY_SELECTION_PASTE if it is not available. > I think it is almost ready but I have some infinite: > > QObject::killTimer: timers cannot be stopped from another thread > > when using Cut/Copy/Paste. I suspect that your patch will help me fix > that. So please put yours first and I'll do the merging. Which one do you mean? The clipboard patch needs some finetuning (which I won't do as explained above), and the other one is waiting for testing. I am not going to put that in without feedback from OS X and windows users, so it seems you have to wait some days. Georg
