On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller spake thusly: > Martin Vermeer wrote: > > OK Jürgen, here is the updated patch > > From a first glance (without looking at the source): > > - What's the "Note" state for which is used by default and does not do > anything obviously?
? I think I called it "blind" note. Of course names are not fixed yet,
just working titles ("disabled"?, "post-it"?)
> - The "branch" input field does not get enabled after switching the combo to
> "branch". I have to close/reopen the dialog and after typing the branch name
> I have to alter the combo again to get OK enabled
Yes, this isn't quite right. I messed up the disabled stuff. (And it's
gonna go once we replace the branch input box by a choice box.)
> - "Petite" is not implemented yet. How is it defined?
I was thinking of one category smaller text, sometimes used to present
material less central to the theme of a text.
> - greyedout does not work (and breaks the latex run)
Ah. Didn't try it. Perhaps it should validate for "color" (?)
> - The comment environment does not use brackets, i.e. it should look like
> \begin{comment}
> text
> \end{comment}
> not
> \begin{comment}{text%
> \end{comment}
I see. That's easy to fix in the NoteInset::latex() method. I just put
stuff there for now; wanted to get the framework right first.
> Also, you should get rid of the comment environment and hassle José to let
> lyx2lyx convert comment environments to comment insets.
:-)
> - wrt branches, I'd emphasize what Michael already said (no need to enter the
> branch name every time).
Working on that; see other post.
> Apart from this, I think this is gonna be a very useful feature. Thanks!
One thing I see no easy way to do would be to have for the branch
notes a "three boxes" drawing method (discussed before) so it
contains running text continuing over the inset edges. This machinery
could then also be used for text style/font insets. Like
+----------------+
[ ]| 1 |
+-----+ |
| 2 |
| +-------+
| 3 |
+--------------+
> Juergen.
Martin
pgp00000.pgp
Description: PGP signature
