On Tue, 27 Feb 2001, Angus Leeming wrote:
> On Monday 26 February 2001 20:06, John Levon wrote:
>
> > > Here we go again ...
> >
> > Angus, I have to put in an ed hack into fdfix.sh. Unless you
> > have bright ideas for a clean way around the problem, now I am avoiding
> > a patch
>
> Yueuchh! I suppose that this can go in for now, but this has definitely gone
> in my list of things to address.
good, I couldn't come up with a nice solution, but then I am not fdfix-fu like you :)
>
> I think that FormFiledialog and form_filedialog should be concerned only with
> the popup. The interaction of LyX with this popup should be through a
> differently named class, eg ControlFileDialog.
Agreed. But of course this was before I saw your new code and how nice things could
be.
> Basically, exactly what you have, but with some name changes. I'm sure we'll
> be able to avoid these problems then.
Not quite as simple as a name change + fixes, look at kde/FileDialog.C, it will need
another layer or something.
> Can somebody apply this patch please.
There were two changelog conflicts [1] from yesterday, that's all. Attached.
cvs add lib/images/file-open.xpm src/frontends/FileDialog.h
src/frontends/xforms/FileDialog.C src/frontends/xforms/FormFiledialog.*
src/frontends/xforms/forms/form_filedialog.fd src/frontends/kde/FileDialog*
cvs add src/frontends/xforms/form_filedialog.*
cvs delete lib/images/buffer-open.xpm src/filedlg.C src/filedlg.h
thanks
john
--
"Creating laws which cannot be universally enforced leads to arbitrary enforcement."
- Upsilon, /.
filetry4.diff.gz
