On Fri, 23 Feb 2001, Dekel Tsur wrote:
> On Fri, Feb 23, 2001 at 04:19:03PM +0000, John Levon wrote:
> > > Index: src/frontends/xforms/FormPreferences.C
> > >
> > > + if (i < 0 || (((::Formats::FormatList::size_type)i) <=
> > > local_formats.size())) {
> > >
> > > I thought we dodn't do C-style casts?
> >
> > You want me to do a typedef instead ? or is the scope resolution
> > operator allowed in C++ style casts ?
>
> Change the line above to
> Formats::FormatList::size_type const i = fl_get_choice(dialog_->choice_from);
> and then you won't need a cast.
Is the assumption that vector::size_type will always be signed acceptable ?
If so, then this would work indeed. I wasn't sure this assumption was OK
john
--
"Anyone who says you can have a lot of widely dispersed people hack away on
a complicated piece of code and avoid total anarchy has never managed a
software project."
- Andy Tanenbaum
