This is NOT a get-at-John day (by the way).
The FileDialog stuff will take some digesting. It's huge!!!!!
As for the rest:
Index: src/frontends/xforms/FormGraphics.C
- string const pattern = "*(ps|png)";
+ // FIXME: currently we need the second '|' to prevent mis-interpretation
+ // FIXME: rfind() in split() seems to be broken hence the second space
+ string const pattern = "*.(ps|png)| ";
wouldn't it be better to fix rfind()?
Index: src/frontends/xforms/FormPreferences.C
+ if (i < 0 || (((::Formats::FormatList::size_type)i) <=
local_formats.size())) {
I thought we dodn't do C-style casts?
Also, why all the extra brackets?
Just comments
A
