On Fri, 23 Feb 2001, Angus Leeming wrote:
> This is NOT a get-at-John day (by the way).
awww, that sounds like fun.
>
> The FileDialog stuff will take some digesting. It's huge!!!!!
but actually very simple in concept. Literally filedlg.C just got moved.
I suppose I should have left the KDE version till later.
> As for the rest:
>
> Index: src/frontends/xforms/FormGraphics.C
>
> - string const pattern = "*(ps|png)";
> + // FIXME: currently we need the second '|' to prevent mis-interpretation
> + // FIXME: rfind() in split() seems to be broken hence the second space
> + string const pattern = "*.(ps|png)| ";
>
> wouldn't it be better to fix rfind()?
Sure it would, but I couldn't see what was wrong immediately. Ideas are welcome
(especially ones that point out what I'm doing wrong).
The first FIXME is really an issue with the FileDialog interface for what
files are in the mask. I haven't decided on the best way to do this yet (even though
it's not used, the hand-made xforms file dialog can handle full regexps, I don't
think the standard KDE one can. Conversely, the KDE file dialog can handle
descriptions of each file type, xforms can't).
>
> Index: src/frontends/xforms/FormPreferences.C
>
> + if (i < 0 || (((::Formats::FormatList::size_type)i) <=
> local_formats.size())) {
>
> I thought we dodn't do C-style casts?
You want me to do a typedef instead ? or is the scope resolution
operator allowed in C++ style casts ?
> Also, why all the extra brackets?
style issue, I always encompass C style casts with explicit brackets.
Don't care about this one.
> Just comments
thanks
john
--
"Anyone who says you can have a lot of widely dispersed people hack away on
a complicated piece of code and avoid total anarchy has never managed a
software project."
- Andy Tanenbaum
