Am 30.01.2016 um 02:11 schrieb Uwe Stöhr:
I propose
that Uwe reverts the layout file changes and makes the 504-505 step an
empty
conversion.
Why? So we want to ship a layout for ACM that nobody can use?
So in fact you are proposing to revert a valid fix the re-enable a
feature of LyX.
Your tex2lyx tests might fail but they are not checking the reality. The
reality is if TeX files can be imported to LyX _and_ if the result can
be compiled. That and not more is what the user expects.
Since only a layout file for a certain document class was changed by me,
it is not possible that tex2lyx gets broken for other files.
I now re-run the tex2lyx tests and it tells me that ALL tests fail. In
fact this is wrong because Guillaume only forgot to update the
fileformat of the tex2lyx test files.
Since tex2lyx itself works fine I doubt that the tex2lyx tests are that
useful as they are. Why can't it handle that the fileformat was changed?
I mean in version.h we stored the fileformat that tex2lyx can handle. So
if the tex2lyx test is run, why are the testfiles not automatically
updated to the new fileformat?
And for the tests I still miss the key feature that the resulting
imported LyX files are compiled to PDF. Because what does it help the
user that he gets a LyX file that he cannot compile. As long as he is no
LaTeX expert it will then be very hard if not impossible to find out why
it does not compile.
However, I won't discuss this again and again. As I promised I won't
touch tex2lyx any more. however, please don't claim commit reversions
only because of failing tex2lyx tests before it is clear that there is a
real problem.
regards Uwe
