Am 03.12.2010 um 04:36 schrieb Enrico Forestieri: > On Fri, Dec 03, 2010 at 12:44:57AM +0100, Pavel Sanda wrote: > >> Stephan Witt wrote: >>> There is a patch pending from Georg. >>> I present it here again and propose to apply it. >>> >>> The second part of the patch is mine. >>> It encapsulates the crucial hasDigit into an ignoreWord() method to >>> prepare to solve the FIXME and to propose an alternate implementation. >>> >>> The latter is not that important... >> >> is Enrico fine with the isDigit part? p > > It's becoming a mess. We have isdigit(), isDigit(), isDigitASCII(), > and now iswdigit() enters the scene.
iswdigit() is POSIX standard for wchar_t arguments - our char_type is a typedef of wchar_t. But I don't insist here. > Too many of those functions, too much confusion. > We should start clearing up things. ... > So, IMHO, we should: > 1) ban isdigit() [use isDigitASCII() instead] > 2) replace all occurrences of isDigit() with isDigitASCII() > 3) use QChar::isNumber() instead of iswdigit(). I'd have no problem with this. My goal was to get the thing fixed. IMHO, a wrapper around QChar::isNumber() in textutils.h and lstrings.cpp should be added then. Stephan
