On Wed, Nov 17, 2010 at 04:19:34PM -0500, Richard Heck wrote: > On 11/17/2010 03:48 PM, Enrico Forestieri wrote: > > > >As regards the other isxxx() tests, I suggest to audit them on an as > >needed basis, according to what the posix standard says: > >http://www.opengroup.org/onlinepubs/9699919799/mindex.html > >(click on the "Alphabetic index" link at the bottom for accessing the > >relevant man page). > > > Both those were ones I introduced, ignorant as I am about these > sorts of issues. So I've fixed them both, I think, but I'd appreciate > if you'd have a look at r36351.
Looks OK to me. However, in lstrings.cpp we also have isAlphaASCII() and isDigitASCII() tests that could be used. I think they convey the real intention more clearly and could be combined for getting a isAlnumASCII() test, too. -- Enrico
