Uwe Stöhr wrote: > > for the ui part - the color is not properly visible here (linux & qt > plastic style). > > What do you mean with "not properly visible"? What color have you set and > how does it look?
the button has grey color with 1 pixel border with the selected color. > > also from qt manuals it folows setStyleSheet is not supported under the > default > > MAC style. > > What is a MAC style, and why is it default on Linux? docs say: "Note: Qt style sheets are currently not supported for QMacStyle (the default style on Mac OS X)." >Besides this, I > implemented it the same way as you set a color in the preferences of the Qt > creator. Qt creator is available for all platforms, so I suppose it works > everywhere. i dont have mac to test. > > the second button is unintuitive, at least tooltip should be added. > > I'll add a tooltip. But why is it unintuitive? It is in my opinion > self-explanatory - just press it and you get its meaning. self explanatory means you look on the icon and get its meaning. i dont see any connection between the arrow icon and removing color. > > maybe we should use the color rectangle plues two buttons - similarly as > we do > > in preferences of colors. > > I don't like this way as one needs a list to draw in the color rectangle. > We only have to set one color here. I looked how other programs set colors > and saw that every programs has its own way. The way I implemented it is > also used by the Qt programs, Mozilla programs (Firefox, Thunderbird), > Adobe programs (Photoshop, Illustrator), AutoCAD, Origin, ... i dont have any strong opinion about the design. but currently the color is not visible here (linux) and there is a hint from docs, that it wont work under MAC at all. before posting the previous mail i have tried myself to change the QToolButton into QPushButton, which helped - the color of button was the right one, but for some mysterious reason setting of button color also changed the background color of colordialog. so i gave up and suggested to use traditional way in pref dialog. > But OK, the next time I'll again post the code for review. thanks pavel
