uwesto...@lyx.org wrote:
> Author: uwestoehr
> Date: Sat Apr 11 23:40:11 2009
> New Revision: 29220
> URL: http://www.lyx.org/trac/changeset/29220
> 
> Log:
> support for \pagecolor, fileformat change
> 

> +void GuiDocument::changeBackgroundColor()
> +{
> +     const QColor newColor = QColorDialog::getColor(
> +             rgb2qcolor(set_backgroundcolor), qApp->focusWidget());
> +     if (!newColor.isValid())
> +             return;
> +     // set the button color
> +     pageLayoutModule->backgroundTB->setStyleSheet(
> +             colorButtonStyleSheet(newColor));

for the ui part - the color is not properly visible here (linux & qt plastic 
style).
also from qt manuals it folows setStyleSheet is not supported under the default 
MAC style.
the second button is unintuitive, at least tooltip should be added.
maybe we should use the color rectangle plues two buttons - similarly as we do 
in
preferences of colors.

maybe you could ask for review on list before commiting stuff like this ?

anyway thanks for colorful easter,
pavel

Reply via email to